Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix iter unicode string #1802

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: fix iter unicode string #1802

merged 1 commit into from
Dec 30, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Dec 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

@He1pa He1pa requested a review from zong-zhe December 30, 2024 03:11
zong-zhe
zong-zhe approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12541302374

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.656%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 84.99%
kclvm/tools/src/LSP/src/request.rs 3 65.34%
kclvm/tools/src/LSP/src/dispatcher.rs 7 65.71%
kclvm/tools/src/LSP/src/state.rs 19 72.33%
Totals Coverage Status
Change from base Build 12479413579: -0.02%
Covered Lines: 52778
Relevant Lines: 74697
💛 - Coveralls

@He1pa He1pa merged commit d9869c3 into main Dec 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zong-zhe zong-zhe zong-zhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@He1pa @coveralls @zong-zhe