-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl format tool. #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
added
tool
Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
enhancement
New feature or request
feat
labels
May 27, 2022
chai2010
previously approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
16 tasks
Peefy
force-pushed
the
dev/peefy/format_tool
branch
from
June 15, 2022 14:39
96925e2
to
39e21ce
Compare
Peefy
force-pushed
the
dev/peefy/format_tool
branch
from
June 30, 2022 07:15
39e21ce
to
b719c3e
Compare
Pull Request Test Coverage Report for Build 2609397302
💛 - Coveralls |
Peefy
force-pushed
the
dev/peefy/format_tool
branch
from
July 4, 2022 10:21
b719c3e
to
ac55874
Compare
ldxdl
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zong-zhe
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
New feature or request
feat
tool
Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Formatting tool rewritten in Rust, Issue Number: #35. The original KCL formatting tool is written in python, which has low performance. It is rewritten using Rust tools according to the content of the route plan #29.
What
KCL Rust version of the Format tool, and provides format APIs to further build tools such as the format CLI
How
The Format tool is built based on AST Printer tool #5. The principle is to parse the code that needs to be formatted into AST through the parser, and then recursively traverse the AST to print it as KCL source code.
PR Merge Deps
#88 Merged
Tests
Unit Tests
src/tools/format/tests.rs
- mainly unit tests for input and output comparison of code with different KCL syntaxBenchmark