Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base64 and net member function types #695

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 4, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #694

feat: add base64 and net member function types

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/builtin/system_module.rs
  • kclvm/sema/src/resolver/attr.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/sema/src/resolver/tests.rs

@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Sep 4, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Sep 4, 2023
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 0f8a2a4 into kcl-lang:main Sep 4, 2023
@Peefy Peefy deleted the enhance-system-package-sema branch September 4, 2023 06:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants