Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsp e2e test. #700

Merged
merged 2 commits into from
Sep 7, 2023
Merged

feat: lsp e2e test. #700

merged 2 commits into from
Sep 7, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 5, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

tools/lsp

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  1. Move unit tests to implement file
  2. add e2e test tools, and add tests for goto_def, completion, hover and fmt
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa changed the title feat: lsp e2e test. Move unit tests to implement file and add e2e tes… [wip] feat: lsp e2e test. Sep 5, 2023
@He1pa He1pa marked this pull request as ready for review September 6, 2023 07:14
@He1pa He1pa changed the title [wip] feat: lsp e2e test. feat: lsp e2e test. Sep 6, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Sep 6, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit d3a1111 into kcl-lang:main Sep 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants