Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kclvm-builder-centos8 docker image #83

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

chai2010
Copy link
Contributor

@chai2010 chai2010 commented Jun 8, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fixes #81

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@chai2010 chai2010 requested review from Peefy, He1pa and zong-zhe June 8, 2022 04:24
Peefy
Peefy previously approved these changes Jun 8, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chai2010 chai2010 force-pushed the fix-chai2010-docker-builder-centos8 branch from fa4c6d2 to 98a8371 Compare June 8, 2022 07:00
@chai2010 chai2010 requested a review from amyXia1994 June 20, 2022 02:28
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chai2010 chai2010 merged commit 67e3913 into main Jun 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
@Peefy Peefy deleted the fix-chai2010-docker-builder-centos8 branch July 13, 2022 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scripts/docker/kclvm-builder-centos8 build failed
3 participants