Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema init in same pkg and add more unit test cases. #87

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 10, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #86

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/ty_alias.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

After the AST resolver checks, the package aliases and type aliases will be substituted. The substitution error will lead to incorrect codegen code generation, resulting in some symbols not being found.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

unit test cases in kclvm/sema/src/resolver/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added bug Something isn't working resolver labels Jun 10, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Jun 10, 2022
@Peefy Peefy requested review from chai2010, ldxdl, He1pa and zong-zhe June 10, 2022 02:35
@Peefy Peefy self-assigned this Jun 10, 2022
chai2010
chai2010 previously approved these changes Jun 10, 2022
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zong-zhe
zong-zhe previously approved these changes Jun 20, 2022
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy dismissed stale reviews from zong-zhe and chai2010 via e6286d4 June 20, 2022 12:34
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2555838846

  • 33 of 44 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.9%) to 39.898%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/ty_alias.rs 17 19 89.47%
kclvm/sema/src/resolver/tests.rs 16 25 64.0%
Totals Coverage Status
Change from base Build 2528852768: 2.9%
Covered Lines: 14550
Relevant Lines: 36468

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chai2010 chai2010 requested review from zong-zhe and chai2010 June 28, 2022 02:26
@Peefy Peefy merged commit b16c03c into main Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
@Peefy Peefy deleted the dev/peefy/fix_init_sub_pkg branch July 13, 2022 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dylib symbol not found in the same package schema statement
4 participants