-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 🐛 cache/replication: fix comparison whether update is needed by removing meta fields #3171
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
504069b
to
0c63bf6
Compare
…g meta field Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
0c63bf6
to
3fc6fdc
Compare
@sttts: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Summary
NOT SURE THIS PR IS CORRECT: found #2935 and kcp-dev/kubernetes#132.
The comparison in the replication controller between cached and local object didn't filter
generation
andmanagedFields
. This was leading to repeated replication.Related issue(s)
Fixes #
Release Notes