Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.26] 🐛 Fix impersonation for non-system users #3214

Merged
merged 2 commits into from
Dec 11, 2024
Merged

[release-0.26] 🐛 Fix impersonation for non-system users #3214

merged 2 commits into from
Dec 11, 2024

Conversation

kcp-ci-bot
Copy link
Contributor

@kcp-ci-bot kcp-ci-bot commented Dec 11, 2024 •
edited by embik
Loading

This is an automated cherry-pick of #3206

/assign mjudeikis

Fix impersonation for non-system users

@kcp-ci-bot kcp-ci-bot mentioned this pull request Dec 11, 2024
Merged
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@embik
Copy link
Member

embik commented Dec 11, 2024

/retest

@embik
Copy link
Member

embik commented Dec 11, 2024

/kind bug

@kcp-ci-bot kcp-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 11, 2024
embik
embik approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@kcp-ci-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 74cca2bd3c1504a1e789c27a9a124c64cf99b7cd

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@mjudeikis mjudeikis force-pushed the cherry-pick-3206-to-release-0.26 branch from 61ab647 to f420b77 Compare December 11, 2024 10:44
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@kcp-ci-bot kcp-ci-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@embik
Copy link
Member

embik commented Dec 11, 2024

/hold

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@mjudeikis mjudeikis force-pushed the cherry-pick-3206-to-release-0.26 branch from f420b77 to 50e8196 Compare December 11, 2024 10:47
@kcp-ci-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 11, 2024
@kcp-ci-bot @mjudeikis
Merge pull request kcp-dev#3211 from embik/remove-ppc64le
2467b59 
⚠️ Stop building artefacts for ppc64le
@kcp-ci-bot kcp-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@embik
Copy link
Member

embik commented Dec 11, 2024

/hold cancel

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 11, 2024
@embik
Copy link
Member

embik commented Dec 11, 2024

/retest

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@kcp-ci-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 323d1d10e4f384282f80d2fa65d9d61d7a37f95e

@kcp-ci-bot kcp-ci-bot merged commit f356b3e into kcp-dev:release-0.26 Dec 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@mjudeikis mjudeikis Awaiting requested review from mjudeikis

Assignees

@mjudeikis mjudeikis

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kcp-ci-bot @embik @mjudeikis