✨ PoC: Implement user scopes #3235
Conversation
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
kcp-ci-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/L
|
@sttts: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -121,6 +112,4 @@ func (a *requiredGroupsAuthorizer) Authorize(ctx context.Context, attr authorize | |||
|
|
|||
| return authorizer.DecisionDeny, fmt.Sprintf("user is not a member of required groups: %s", logicalCluster.Annotations[RequiredGroupsAnnotationKey]), nil | |||
| } | |||
|
|
|||
| return authorizer.DecisionNoOpinion, WorkspaceAccessNotPermittedReason, nil | |||
There was a problem hiding this comment.
Why this went away? Because we do loop for this now?
| wantAllowed bool | ||
| } | ||
| for _, tt := range []tests{ | ||
| {name: "normal user", user: "user", groups: []string{"system:kcp:admin"}, wantAllowed: true}, |
There was a problem hiding this comment.
just a note, can we make this more readable with few /n? :)
Summary
This is towards warrant support in #3156.
Related issue(s)
Release Notes