btrfs: xattr: remove unnecessary call to btrfs_mark_buffer_dirty()

The call to btrfs_mark_buffer_dirty() at btrfs_setxattr() is not necessary as we have a path setup for writing with btrfs_search_slot() having a 'cow' argument set to 1. This just makes the code more verbose, confusing and add a little extra overhead and well as increase the module's text size, so remove it. Signed-off-by: Filipe Manana <[email protected]> Signed-off-by: David Sterba <[email protected]>
kdave · Dec 23, 2024 · b0a99cc · b0a99cc
1 parent 7c82343
commit b0a99cc
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/fs/btrfs/xattr.c b/fs/btrfs/xattr.c
@@ -204,7 +204,6 @@ int btrfs_setxattr(struct btrfs_trans_handle *trans, struct inode *inode,
 		btrfs_set_dir_data_len(leaf, di, size);
 		data_ptr = ((unsigned long)(di + 1)) + name_len;
 		write_extent_buffer(leaf, value, data_ptr, size);
-		btrfs_mark_buffer_dirty(trans, leaf);
 	} else {
 		/*
 		 * Insert, and we had space for the xattr, so path->slots[0] is