Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive subvolume deletion only reports upper snapshot deletion. #923

Open
CorrosiveTruths opened this issue Nov 18, 2024 · 1 comment
Labels

Comments

@CorrosiveTruths
Copy link

Might be a little premature, but was expecting the new recursive subvolume delete to report all the subvolumes deleted rather than just the upper level subvolume.

So with:

# btrfs sub create butts && btrfs sub create butts/butts && btrfs sub create butts/butts/butts
Create subvolume './butts'
Create subvolume 'butts/butts'
Create subvolume 'butts/butts/butts'

Would expect something like:

# btrfs --dry-run sub del -R butts
Delete subvolume 5896 (no-commit): '/root/btrfs-progs/butts/butts/butts'
Delete subvolume 5895 (no-commit): '/root/btrfs-progs/butts/butts'
Delete subvolume 5894 (no-commit): '/root/btrfs-progs/butts'

But you get:

# btrfs --dry-run sub del -R butts
Delete subvolume 5894 (no-commit): '/root/btrfs-progs/butts'

@kdave kdave added the bug label Nov 27, 2024
@realwakka
Copy link
Contributor

Hi, I submitted a patch for this issue. https://lore.kernel.org/linux-btrfs/[email protected]/T/#u
I would appreciate for review. Thanks.

realwakka added a commit to realwakka/btrfs-progs that referenced this issue Feb 15, 2025
When a subvolume is deleted with the recursive option, any nested (child)
subvolumes also get removed without report it. This patch modifies the
delete subvol command to print a listt of child subvolumes during
recursive deletion.

Issue: kdave#923

Signed-off-by: Sidong Yang <[email protected]>
kdave pushed a commit that referenced this issue Feb 20, 2025
…elete

When a subvolume is deleted with the recursive option, any nested
subvolumes also get removed without reporting it. Update the subvolume
delete command to print the list of nested subvolumes.

Issue: #923
Signed-off-by: Sidong Yang <[email protected]>
Signed-off-by: David Sterba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants