qgroup clear-stale calls sync() even without quotas enabled #942
Comments
kdave
added a commit
that referenced
this issue
Jan 28, 2025
If qgroups are not enabled the 'clear-stale' command unconditionally calls sync on the whole filesystem, which is unnecessary and can slow down the system. Do a check first if qgroups are enabled. Issue: #942 Signed-off-by: David Sterba <[email protected]>
kdave
added a commit
that referenced
this issue
Jan 28, 2025
If qgroups are not enabled the 'clear-stale' command unconditionally calls sync on the whole filesystem, which is unnecessary and can slow down the system. Do a check first if qgroups are enabled. Issue: #942 Signed-off-by: David Sterba <[email protected]>
kdave
added a commit
that referenced
this issue
Feb 11, 2025
If qgroups are not enabled the 'clear-stale' command unconditionally calls sync on the whole filesystem, which is unnecessary and can slow down the system. Do a check first if qgroups are enabled. Issue: #942 Signed-off-by: David Sterba <[email protected]>
|
Fixed in devel, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
btrfs qgroup clear-stalecalls sync (viabtrfs_util_sync_fd()) in cmd/qgroup.c line 2213 before figuring out whether quotas are enabled at all (in line 2219).This causes unnecessary delays on a system which does not enable quotas, but which uses tools which call this quota-related command. Could you please find out whether quotas are enabled first?
The text was updated successfully, but these errors were encountered: