Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDL 2.0: identifier-based quoteless strings #339

Closed
zkat opened this issue Nov 28, 2023 · 4 comments
Closed

KDL 2.0: identifier-based quoteless strings #339

zkat opened this issue Nov 28, 2023 · 4 comments
Labels
breaking This can only be done for the next major version of KDL enhancement New feature or request

Comments

@zkat
Copy link
Member

zkat commented Nov 28, 2023

I thought a lot about this (and we've talked about this at length in #308, but I think we should just do it, and that it's going to be ok. In practice, there will be ways to catch typos in a reasonable way, and I think quoteless strings (following identifier syntax) are actually a huge UX improvement for human-authored/maintained configuration files.

Feel free to protest this change here, or up/downvote with reactji, but I'm now leaning towards this being a major KDL 2.0 change.

@zkat zkat added enhancement New feature or request breaking This can only be done for the next major version of KDL labels Nov 28, 2023
@larsgw
Copy link
Contributor

larsgw commented Nov 29, 2023

I think this, especially when combined with #340, can be very confusing. Of course a good linter can prevent such confusion. E.g.

ident ident ident          =ident

Or

ident ident = ident ident

@zkat
Copy link
Member Author

zkat commented Dec 9, 2023

After thinking about it I think I'm going to withdraw this. I have an alternative proposal.

@zkat zkat closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2023
@zkat
Copy link
Member Author

zkat commented Dec 12, 2023

After conversation in #350, it looks like this is what we're gonna go with after all...

@zkat
Copy link
Member Author

zkat commented Dec 13, 2023

This has been merged into the kdl-v2 branch

@zkat zkat closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This can only be done for the next major version of KDL enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants