Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KQL: require operator and change operator grammar a bit #221

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

zkat
Copy link
Member

@zkat zkat commented Oct 6, 2021

Ref: #204 (comment)

This just makes it so "operators" are required, meaning we don't have to worry about syntax ambiguity with bare identifiers anymore :)

@zkat zkat requested a review from larsgw October 6, 2021 05:11
@zkat
Copy link
Member Author

zkat commented Oct 6, 2021

cc @tabatkins @larsgw I'd love your feedback

@zkat zkat added the breaking This can only be done for the next major version of KDL label Oct 6, 2021
@larsgw
Copy link
Contributor

larsgw commented Oct 6, 2021

Looks good to me, did you see this page from the CSS WG being tweeted yesterday? https://wiki.csswg.org/ideas/mistakes

Incomplete List of Mistakes in the Design of CSS

...

  • descendant combinator should have been » and indirect sibling combinator should have been ++, so there's some logical relationships among the selectors' ascii art

@zkat zkat merged commit 69ac280 into kdl-v2 Aug 28, 2022
@zkat zkat deleted the zkat/query-operator-required branch August 28, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This can only be done for the next major version of KDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants