Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of syntactically significant unicode equals signs #400

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

zkat
Copy link
Member

@zkat zkat commented Oct 5, 2024

Fixes: #399

@zkat zkat requested review from borland, tabatkins and larsgw October 5, 2024 21:32
@zkat zkat added the breaking This can only be done for the next major version of KDL label Oct 5, 2024
SPEC.md Outdated
Comment on lines 134 to 143
#### Equals Sign

Any of the following characters may be used as equals signs in properties:
Only the following character may be used as equals signs in properties:

| Name | Character | Code Point |
|----|-----|----|
| EQUALS SIGN | `=` | `U+003D` |
| SMALL EQUALS SIGN | `﹦` | `U+FE66` |
| FULLWIDTH EQUALS SIGN | `=` | `U+FF1D` |
| HEAVY EQUALS SIGN | `🟰` | `U+1F7F0` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to keep this section? It's has only one reference, in the previous section, that could be replaced with "equals sign (=, code point U+003D)". Regardless, the previous section might need to be reworded anyway (#401).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@zkat zkat requested a review from larsgw November 27, 2024 07:42
@zkat zkat force-pushed the zkat/one-equals-to-rule-them-all branch 3 times, most recently from daa4a6e to 3c2f103 Compare November 27, 2024 09:03
Copy link
Contributor

@larsgw larsgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that the example in the readme is now outdated:

// And you can also use unicode, even for the equals sign!
ノード お名前=☜(゚ヮ゚☜)

@zkat zkat requested a review from larsgw November 28, 2024 01:31
@zkat zkat force-pushed the zkat/one-equals-to-rule-them-all branch from 8133431 to c81fa4d Compare November 28, 2024 08:21
@zkat zkat linked an issue Nov 28, 2024 that may be closed by this pull request
@zkat zkat merged commit 1588b1f into kdl-v2 Nov 29, 2024
@zkat zkat deleted the zkat/one-equals-to-rule-them-all branch November 29, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This can only be done for the next major version of KDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] Remove = normalization
2 participants