fix stan

keboola · Sep 24, 2024 · a6ab681 · a6ab681
1 parent 6168eb0
commit a6ab681
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tests/Backend/ExternalBuckets/SnowflakeRegisterBucketTest.php b/tests/Backend/ExternalBuckets/SnowflakeRegisterBucketTest.php
@@ -1238,7 +1238,7 @@ public function testDropExternalBucket(): void
         $this->assertEquals($dataFromBucket2BeforeDeletion, $dataFrom2AfterDeletion);
     }
 
-    public function testGuideInBranch()
+    public function testGuideInBranch(): void
     {
         $guide = $this->_client->registerBucketGuide([self::EXTERNAL_DB, self::EXTERNAL_SCHEMA], 'snowflake');
         $this->assertStringContainsString('GRANT USAGE ON DATABASE', $guide['markdown']);
@@ -1256,6 +1256,7 @@ public function testGuideInBranch()
         try {
             $branchAwareClient = $this->getBranchAwareDefaultClient($newBranch['id']);
             $branchAwareClient->registerBucketGuide(['DB', 'SCHEMA'], 'snowflake');
+            $this->fail('Should fail');
         } catch (ClientException $e) {
             $this->assertEquals('This endpoint is available in the default branch only.', $e->getMessage());
         }

diff --git a/tests/Backend/SOX/SOXBranchesTest.php b/tests/Backend/SOX/SOXBranchesTest.php
@@ -113,14 +113,14 @@ public function testDeveloperReviewerCanManageEachOtherBranches(): void
         $developerBranches->deleteBranch($testBranchId);
     }
 
-    public function testProdManagerCanRegisterExternal()
+    public function testProdManagerCanRegisterExternal(): void
     {
         $privilegedClient = $this->getDefaultBranchStorageApiClient();
         $guide = $privilegedClient->registerBucketGuide(['TEST', 'SCHEMA'], 'snowflake');
         $this->assertStringContainsString('GRANT USAGE ON DATABASE', $guide['markdown']);
     }
 
-    public function testDevelopersAndReviewersCannotRegisterExternalBucket()
+    public function testDevelopersAndReviewersCannotRegisterExternalBucket(): void
     {
         $developerClient = $this->getDeveloperStorageApiClient();
         $reviewerClient = $this->getReviewerStorageApiClient();