Skip to content

Commit

Permalink
remove webhooks.enabled config option
Browse files Browse the repository at this point in the history
Signed-off-by: Jan Wozniak <[email protected]>
  • Loading branch information
wozniakjan committed Jan 19, 2024
1 parent 2031d66 commit bdfa5ed
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion keda/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ their default values.
| `volumes.webhooks.extraVolumeMounts` | list | `[]` | Extra volume mounts for admission webhooks deployment |
| `volumes.webhooks.extraVolumes` | list | `[]` | Extra volumes for admission webhooks deployment |
| `webhooks.affinity` | object | `{}` | [Affinity] for pod scheduling for KEDA admission webhooks. Takes precedence over the `affinity` field |
| `webhooks.enabled` | bool | `true` | Enable admission webhooks (this feature option will be removed in v2.12) |
| `webhooks.failurePolicy` | string | `"Ignore"` | [Failure policy](https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#failure-policy) to use with KEDA admission webhooks |
| `webhooks.healthProbePort` | int | `8081` | Port number to use for KEDA admission webhooks health probe |
| `webhooks.livenessProbe` | object | `{"failureThreshold":3,"initialDelaySeconds":25,"periodSeconds":10,"successThreshold":1,"timeoutSeconds":1}` | Liveness probes for admission webhooks ([docs](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/)) |
Expand Down
2 changes: 0 additions & 2 deletions keda/templates/webhooks/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- if and .Values.webhooks.enabled }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down Expand Up @@ -174,4 +173,3 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- end }}
2 changes: 0 additions & 2 deletions keda/templates/webhooks/poddisruptionbudget.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- if and .Values.webhooks.enabled }}
{{- if or (or .Values.podDisruptionBudget.minAvailable .Values.podDisruptionBudget.maxUnavailable) .Values.podDisruptionBudget.webhooks }}
apiVersion: policy/v1
kind: PodDisruptionBudget
Expand Down Expand Up @@ -30,5 +29,4 @@ spec:
selector:
matchLabels:
app: {{ .Values.webhooks.name }}
{{- end }}
{{- end }}
2 changes: 0 additions & 2 deletions keda/templates/webhooks/prometheusrules.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- if and .Values.webhooks.enabled }}
{{- if and .Values.prometheus.webhooks.enabled .Values.prometheus.webhooks.prometheusRules.enabled }}
apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
Expand All @@ -22,5 +21,4 @@ spec:
- name: {{ .Values.webhooks.name }}
rules:
{{ toYaml .Values.prometheus.webhooks.prometheusRules.alerts | indent 6 }}
{{- end }}
{{- end }}
2 changes: 0 additions & 2 deletions keda/templates/webhooks/service.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- if and .Values.webhooks.enabled }}
apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -43,4 +42,3 @@ spec:
{{- end }}
selector:
app: {{ .Values.webhooks.name }}
{{- end }}
2 changes: 0 additions & 2 deletions keda/templates/webhooks/servicemonitor.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- if and .Values.webhooks.enabled }}
{{- if and .Values.prometheus.webhooks.enabled .Values.prometheus.webhooks.serviceMonitor.enabled }}
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
Expand Down Expand Up @@ -59,4 +58,3 @@ spec:
matchLabels:
app.kubernetes.io/name: {{ .Values.webhooks.name }}
{{- end }}
{{- end }}
2 changes: 0 additions & 2 deletions keda/templates/webhooks/validatingconfiguration.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- if and .Values.webhooks.enabled }}
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
Expand Down Expand Up @@ -92,4 +91,3 @@ webhooks:
- clustertriggerauthentications
sideEffects: None
timeoutSeconds: 10
{{- end }}
2 changes: 0 additions & 2 deletions keda/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,6 @@ metricsServer:
successThreshold: 1

webhooks:
# -- Enable admission webhooks (this feature option will be removed in v2.12)
enabled: true
# -- Port number to use for KEDA admission webhooks. Default is 9443.
port: ""
# -- Port number to use for KEDA admission webhooks health probe
Expand Down

0 comments on commit bdfa5ed

Please sign in to comment.