Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some linting issues #123

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Conversation

ubergesundheit
Copy link
Contributor

@ubergesundheit ubergesundheit commented Feb 16, 2021

This PR resolves some linting issues I noticed after running ct lint --validate-maintainers=false --charts=keda/ (https://github.com/helm/chart-testing)

Checklist

Signed-off-by: Gerald Pape <[email protected]>
@tomkerkhove
Copy link
Member

Thanks for the PR! We have it open on #84 but we are not sure if we will change it given it's a breaking change. /cc @zroubalik

@ubergesundheit
Copy link
Contributor Author

Are you fine with me leaving this one open since it also fixes a trailing white space?

@tomkerkhove
Copy link
Member

Can you get the role change out so we can merge the other fixes already?

@ubergesundheit
Copy link
Contributor Author

Sure. See 0c01d36

@tomkerkhove
Copy link
Member

tomkerkhove commented Feb 17, 2021

Thank you for this contribution @ubergesundheit!

@tomkerkhove tomkerkhove merged commit 5ea7d81 into kedacore:master Feb 17, 2021
@ubergesundheit ubergesundheit deleted the chart-validation branch February 17, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants