feat: add support to validating webhooks #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
JorTurFer
force-pushed
the
validation-hook
branch
4 times, most recently
from
32fb043 to
955b37d
Compare
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
force-pushed
the
validation-hook
branch
from
840f19a to
35668f4
Compare
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
changed the title
Signed-off-by: Jorge Turrado <[email protected]>
zroubalik
approved these changes
Jan 13, 2023
|
f**k! I thought I was clicking in auto-merge but I this repo doesn't have it because there isn't required checks, I hope all will pass, if not I'll solve the issues in other PR |
tomkerkhove
reviewed
Jan 13, 2023
| @@ -52,6 +56,23 @@ metricsServer: | |||
| # - keda-operator-metrics-apiserver | |||
| # topologyKey: "kubernetes.io/hostname" | |||
|
|
|||
| webhooks: | |||
| enabled: true # This value will be removed in keda v2.12 | |||
There was a problem hiding this comment.
Because we talked about making this not optional in KEDA, Am I wrong?
There was a problem hiding this comment.
I have to solve the issues I generated with the early merge, I can remove the comment if you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Turrado [email protected]
To pass CI checks here, the feature needs to be merged in KEDA because the new image is required for CI checks here
Checklist
Fixes kedacore/keda#3755
Fixes kedacore/keda#3087
Fixes kedacore/keda#3083
Fixes kedacore/keda#3088