Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additional annotation being rendered in the same line with a static annotation #353

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Fix additional annotation being rendered in the same line with a static annotation #353

merged 1 commit into from
Jan 6, 2023

Conversation

RomanBats
Copy link
Contributor

@RomanBats RomanBats commented Jan 4, 2023 •
edited
Loading

When additionalAnnotations is set - the chart is rendered with the first additional annotation on the same line with a static annotation.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

@RomanBats RomanBats requested a review from a team as a code owner January 4, 2023 09:02
@RomanBats RomanBats changed the title Main Fix additional annotation being rendered in the same line with a static annotation Jan 4, 2023
@tomkerkhove
Copy link
Member

Hi, would you mind sharing an example before and after the change please?

@RomanBats
Copy link
Contributor Author

@tomkerkhove, so when i run:

helm template . --set additionalAnnotations.test=value --debug

I am getting this:
image

In the fixed version I get this:
image

@tomkerkhove tomkerkhove merged commit c3db80d into kedacore:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomanBats @tomkerkhove