Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for configuring KEDA_HTTP_MIN_TLS_VERSION #388

Merged
merged 2 commits into from
Feb 9, 2023
Merged

chore: add support for configuring KEDA_HTTP_MIN_TLS_VERSION #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8590a64
chore: add support to KEDA_HTTP_MIN_TLS_VERSION
JorTurFer Feb 3, 2023
556ac66
add minTlsVersion to readme
JorTurFer Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions keda/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ their default values.
| `extraArgs.metricsAdapter` | Additional Metrics Adapter container arguments | `{}` |
| `env` | Additional environment variables that will be passed onto KEDA operator and metrics api service | `` |
| `http.timeout` | The default HTTP timeout to use for all scalers that use raw HTTP clients (some scalers use SDKs to access target services. These have built-in HTTP clients, and the timeout does not necessarily apply to them) | `` |
| `http.minTlsVersion` | The minimum TLS version to use for all scalers that use raw HTTP clients (some scalers use SDKs to access target services. These have built-in HTTP clients, and this value does not necessarily apply to them) | `` |
| `service.annotations` | Annotations to add the KEDA Metric Server service | `{}` |
| `service.portHttp` | Service HTTP port for KEDA Metric Server service | `80` |
| `service.portHttpTarget` | Service HTTP port for KEDA Metric Server container | `8080` |
Expand Down
4 changes: 2 additions & 2 deletions keda/templates/14-keda-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ spec:
fieldPath: metadata.name
- name: OPERATOR_NAME
value: {{ .Values.operator.name }}
{{- if .Values.http.timeout }}
- name: KEDA_HTTP_DEFAULT_TIMEOUT
value: {{ .Values.http.timeout | quote }}
{{- end }}
- name: KEDA_HTTP_MIN_TLS_VERSION
value: {{ .Values.http.minTlsVersion }}
{{- if ( not .Values.http.keepAlive.enabled ) }}
- name: KEDA_HTTP_DISABLE_KEEP_ALIVE
value: "true"
Expand Down
4 changes: 2 additions & 2 deletions keda/templates/22-metrics-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ spec:
env:
- name: WATCH_NAMESPACE
value: {{ .Values.watchNamespace | quote }}
{{- if .Values.http.timeout }}
zroubalik marked this conversation as resolved.
Show resolved Hide resolved
- name: KEDA_HTTP_DEFAULT_TIMEOUT
value: {{ .Values.http.timeout | quote }}
{{- end }}
- name: KEDA_HTTP_MIN_TLS_VERSION
tomkerkhove marked this conversation as resolved.
Show resolved Hide resolved
value: {{ .Values.http.minTlsVersion }}
{{- if ( not .Values.http.keepAlive.enabled ) }}
- name: KEDA_HTTP_DISABLE_KEEP_ALIVE
value: "true"
Expand Down
1 change: 1 addition & 0 deletions keda/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ http:
timeout: 3000
keepAlive:
enabled: true
minTlsVersion: TLS12
JorTurFer marked this conversation as resolved.
Show resolved Hide resolved

## Extra KEDA Operator and Metrics Adapter container arguments
extraArgs:
Expand Down