Re-introduce support for Helm v2.x #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
tomkerkhove
requested review from
ahmelsayed,
jeffhollan and
zroubalik
as code owners
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
|
It works again but not sure if we can fix the Helm 2 deployment - helm/helm#6783 |
zroubalik
approved these changes
Oct 29, 2020
wozniakjan
pushed a commit
to wozniakjan/keda-charts
that referenced
this pull request
Jan 22, 2025
Signed-off-by: Jirka Kremser <[email protected]>
wozniakjan
pushed a commit
to wozniakjan/keda-charts
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Jirka Kremser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Kerkhove [email protected]
Re-introduce support for Helm v2.x as mitigation for Helm chart issues in 2.0.0-rc2 with CRD issues until #88 is fixed for Helm v3.x only.
This ships
2.0.0-rc3as a mitigation until fix is found, sorry people for this change. We've introduced Kind clusters to our CI to avoid this from happening in the future.Reopens #81
Reverts #82