Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): use correct service name #1244

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

ldvc
Copy link
Contributor

@ldvc ldvc commented Jan 31, 2025

Correct the service name used in the walkthrough documentation

After a fresh installation, the following services are available:

➜ k get services -n keda -o name | grep http
service/keda-add-ons-http-controller-manager-metrics-service
service/keda-add-ons-http-external-scaler
service/keda-add-ons-http-interceptor-admin
service/keda-add-ons-http-interceptor-proxy

Checklist

Fixes #

@ldvc ldvc requested a review from a team as a code owner January 31, 2025 10:44
@ldvc ldvc force-pushed the doc-fix-service-name branch from d9d5fd5 to abd0caa Compare January 31, 2025 10:47
Signed-off-by: Ludovic Terrier <[email protected]>
@ldvc ldvc force-pushed the doc-fix-service-name branch from abd0caa to 98936d0 Compare January 31, 2025 10:50
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan merged commit 54d0ec6 into kedacore:main Jan 31, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants