Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring operator updates ScaledObject on all HTTPScaledObject changes #324

Closed
wants to merge 3 commits into from
Closed

Ensuring operator updates ScaledObject on all HTTPScaledObject changes #324

wants to merge 3 commits into from

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Nov 15, 2021 •
edited
Loading

In certain situations, a valid update to an HTTPScaledObject won't trigger any in-kind update to the corresponding ScaledObject

Checklist

Fixes #323
Fixes #20

@arschles arschles modified the milestones: v0.3.0, v0.2.1 Nov 15, 2021
@arschles
Copy link
Collaborator Author

@tpiperatgod could you take a look at this when you have a chance? It's almost ready but I would appreciate your review.

@arschles arschles marked this pull request as ready for review January 13, 2022 23:15
@arschles arschles force-pushed the update-replicas branch 2 times, most recently from 385c99f to 6942b8e Compare January 14, 2022 18:54
@arschles arschles modified the milestones: v0.3.0, v0.4.0 Jan 27, 2022
bketelsen
bketelsen approved these changes Feb 16, 2022
View reviewed changes
Copy link

@bketelsen bketelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asw101
asw101 reviewed Feb 17, 2022
View reviewed changes
pkg/k8s/scaledobject.go Outdated
Comment on lines 30 to 34
func DeleteScaledObject(
ctx context.Context,
ns,
name string,
cl client.Client,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw we flipped name and ns, and it looks fine, but might it make sense to match the signature of GetScaledObject for consistency (referenced in operator/controllers/app.go:108 ) -- for example:

func DeleteScaledObject(
	ctx context.Context,
	cl client.Client,
	ns,
	name string,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. thanks, fixed in 243be6c

pkg/k8s/client_fake.go Outdated Show resolved Hide resolved
pkg/k8s/client_fake.go Outdated Show resolved Hide resolved
operator/controllers/routing_table_test.go Outdated Show resolved Hide resolved
operator/controllers/httpscaledobject_controller_test.go Outdated Show resolved Hide resolved
operator/controllers/httpscaledobject_controller_test.go Outdated Show resolved Hide resolved
@tpiperatgod
Copy link
Contributor

@tpiperatgod could you take a look at this when you have a chance? It's almost ready but I would appreciate your review.

Sorry, I'm just now seeing this, I think it will solve my issue, thanks @arschles !

@dependabot @arschles
Patching ScaledObjects when creation failed with an "already exists" …
f79d4d2 
…error

Plus more refactors as necessary

Signed-off-by: Aaron Schlesinger <[email protected]>

Updating the release process document with correct order of operations (kedacore#327)

* updating the release process document

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding information about the chart's images.tag field in values.yaml

Signed-off-by: Aaron Schlesinger <[email protected]>

Bump k8s.io/apimachinery from 0.22.3 to 0.22.4 (kedacore#328)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.22.3 to 0.22.4.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.22.3...v0.22.4)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump k8s.io/client-go from 0.22.2 to 0.22.4 (kedacore#329)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.22.2 to 0.22.4.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.22.2...v0.22.4)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump google.golang.org/grpc from 1.41.0 to 1.42.0 (kedacore#312)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.41.0...v1.42.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Schlesinger <[email protected]>

Add configMap informer (kedacore#326)

Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>

Co-authored-by: Aaron Schlesinger <[email protected]>

Restore target to original replica count after deleting httpscaledobject resource. (kedacore#339)

Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>

Co-authored-by: Aaron Schlesinger <[email protected]>

Upgrading images to use Go 1.17.2 (kedacore#349)

Adding documentation for how to issue curl requests (kedacore#347)

Signed-off-by: Aaron Schlesinger <[email protected]>

chore: Allow blank issues (kedacore#352)

Signed-off-by: Tom Kerkhove <[email protected]>

Bump github.com/magefile/mage from 1.11.0 to 1.12.1 (kedacore#360)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump google.golang.org/grpc from 1.42.0 to 1.43.0 (kedacore#358)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

converting bug report issue template to a form issue (kedacore#363)

Signed-off-by: Aaron Schlesinger <[email protected]>

Allowing cluster-global operation (kedacore#269)

* Allowing cluster-global operation

Signed-off-by: Aaron Schlesinger <[email protected]>

* passing less unnecessary data in the operator

Signed-off-by: Aaron Schlesinger <[email protected]>

* setting namespace

Signed-off-by: Aaron Schlesinger <[email protected]>

* updating tests:

Signed-off-by: Aaron Schlesinger <[email protected]>

* Updating deployment cache interfaces

To accommodate multi-namespace gets and watches

Signed-off-by: Aaron Schlesinger <[email protected]>

* starting on deployment cache informer

Signed-off-by: Aaron Schlesinger <[email protected]>

* switching over to informer-based deployment cache

Signed-off-by: Aaron Schlesinger <[email protected]>

* fixing test compile errors and merging fake and in-memory deployment caches

Signed-off-by: Aaron <[email protected]>

* fixing tests

Signed-off-by: Aaron Schlesinger <[email protected]>

* fixing more compile errs

Signed-off-by: Aaron Schlesinger <[email protected]>

* improving logging, and several other small changes

Signed-off-by: Aaron Schlesinger <[email protected]>

* go mod tidy

Signed-off-by: Aaron Schlesinger <[email protected]>

* Adding config validation

Signed-off-by: Aaron Schlesinger <[email protected]>

* improving ns and svc name var names to indicate interceptor

Signed-off-by: Aaron Schlesinger <[email protected]>

* running go mod tidy

Signed-off-by: Aaron Schlesinger <[email protected]>

* removing unused code

Signed-off-by: Aaron Schlesinger <[email protected]>

* passing a function to transform target to in-cluster URL

Signed-off-by: Aaron Schlesinger <[email protected]>

* not requiring namespace for operator

Signed-off-by: Aaron Schlesinger <[email protected]>

* splitting namespace config for operator into watch and current

Signed-off-by: Aaron Schlesinger <[email protected]>

* removing appInfo, passing current namespace everywhere in its place

Signed-off-by: Aaron Schlesinger <[email protected]>

* using proper namespace when creating scaled object

Signed-off-by: Aaron Schlesinger <[email protected]>

* allowing xkcd chart to set ingress namespace

Signed-off-by: Aaron Schlesinger <[email protected]>

* printing namespace in error

Signed-off-by: Aaron Schlesinger <[email protected]>

* using proper fully-qualified hostname of external scaler in scaledobject

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding note on cluster-global vs. namespaced mode

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding note about installing the xkcd chart in cluster-global mode

Signed-off-by: Aaron Schlesinger <[email protected]>

* fixing hostname test

Signed-off-by: Aaron Schlesinger <[email protected]>

* merging scaler queue counts with routing table hosts. removing merge functionality from interceptors

Signed-off-by: Aaron Schlesinger <[email protected]>

* fix assumption in tests that queue has all hosts from routing table

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding test for MergeCountsWithRoutingTable

Signed-off-by: Aaron Schlesinger <[email protected]>

* sleep for longer to wait for server to start

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding handler test for merging hosts

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding test to GetMetrics test cases for host not in queue pinger

Signed-off-by: Aaron Schlesinger <[email protected]>

Return custom header when request was returned from a cold start  (kedacore#366)

* Add X-KEDA-HTTP-Cold-Start header

- Add X-KEDA-HTTP-Cold-Start header
- Change signature of forwardWaitFunc to include deployment.Status.ReadyReplicas

Signed-off-by: Aaron Wislang <[email protected]>

* Update tests for X-KEDA-HTTP-Cold-Start header

Signed-off-by: Aaron Wislang <[email protected]>

* Update interceptor/main_test.go

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* add bracket

Signed-off-by: Aaron Wislang <[email protected]>

Co-authored-by: Aaron Schlesinger <[email protected]>

Updating dependencies (kedacore#348)

* updating dependencies

Signed-off-by: Aaron Schlesinger <[email protected]>

* NullLogger => Discard()

Signed-off-by: Aaron Schlesinger <[email protected]>

* removing redundant import

Signed-off-by: Aaron Schlesinger <[email protected]>

* updating to use go 1.17.2

Signed-off-by: Aaron Schlesinger <[email protected]>

* upgrading vulnerable packages

Signed-off-by: Aaron Schlesinger <[email protected]>

* upgrading sftp

Signed-off-by: Aaron Schlesinger <[email protected]>

* force-upgrading sftp

Signed-off-by: Aaron Schlesinger <[email protected]>

Bump go.uber.org/zap from 1.19.1 to 1.20.0 (kedacore#362)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump github.com/go-logr/zapr from 0.4.0 to 1.2.2 (kedacore#357)

Bumps [github.com/go-logr/zapr](https://github.com/go-logr/zapr) from 0.4.0 to 1.2.2.
- [Release notes](https://github.com/go-logr/zapr/releases)
- [Commits](go-logr/zapr@v0.4.0...v1.2.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/zapr
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump k8s.io/apimachinery from 0.23.1 to 0.23.2 (kedacore#376)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.1 to 0.23.2.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.23.1...v0.23.2)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump k8s.io/client-go from 0.23.1 to 0.23.2 (kedacore#375)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.23.1...v0.23.2)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Compile binaries and docker images with git SHA (kedacore#377)

* Compile binaries and docker images with git SHA

Signed-off-by: Aaron Wislang <[email protected]>
Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net>

* Fix test

Signed-off-by: Aaron Wislang <[email protected]>
Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net>

* Apply suggestions from @arschles

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net>

Co-authored-by: Aaron Schlesinger <[email protected]>

Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (kedacore#378)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Configure WhiteSource Bolt for GitHub (kedacore#379)

Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <[email protected]>

adding targetPendingRequests to the xkcd helm chart (kedacore#373)

Signed-off-by: Aaron Schlesinger <[email protected]>

fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (kedacore#372)

Signed-off-by: Aaron Schlesinger <[email protected]>

Add TestStreamIsActive (kedacore#384)

* Return IsActive error vs log and continue

Signed-off-by: Aaron Wislang <[email protected]>

* Add TestStreamIsActive

Signed-off-by: Aaron Wislang <[email protected]>

* Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (kedacore#378)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Aaron Wislang <[email protected]>

* Configure WhiteSource Bolt for GitHub (kedacore#379)

Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* adding targetPendingRequests to the xkcd helm chart (kedacore#373)

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (kedacore#372)

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* defer grpcServer.Stop()

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* Don't check error for gprServer

Signed-off-by: Aaron Wislang <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Aaron Schlesinger <[email protected]>

Bump go.uber.org/zap from 1.20.0 to 1.21.0 (kedacore#394)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.20.0 to 1.21.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.20.0...v1.21.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump google.golang.org/grpc from 1.43.0 to 1.44.0 (kedacore#390)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.43.0 to 1.44.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.43.0...v1.44.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump github.com/onsi/gomega from 1.18.0 to 1.18.1 (kedacore#393)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.18.0...v1.18.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump k8s.io/apimachinery from 0.23.2 to 0.23.3 (kedacore#392)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.2 to 0.23.3.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.23.2...v0.23.3)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump k8s.io/api from 0.23.2 to 0.23.3 (kedacore#389)

Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.23.2 to 0.23.3.
- [Release notes](https://github.com/kubernetes/api/releases)
- [Commits](kubernetes/api@v0.23.2...v0.23.3)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix shell typo in docs (kedacore#395)

Signed-off-by: XinYang <[email protected]>

fix documentation for creating an HTTPScaledObject (kedacore#351)

* fix documentation for creating an HTTPScaledObject

Signed-off-by: Marco Piovesana <[email protected]>

* chore: Allow blank issues (kedacore#352)

Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump github.com/magefile/mage from 1.11.0 to 1.12.1 (kedacore#360)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump google.golang.org/grpc from 1.42.0 to 1.43.0 (kedacore#358)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* converting bug report issue template to a form issue (kedacore#363)

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* Allowing cluster-global operation (kedacore#269)

* Allowing cluster-global operation

Signed-off-by: Aaron Schlesinger <[email protected]>

* passing less unnecessary data in the operator

Signed-off-by: Aaron Schlesinger <[email protected]>

* setting namespace

Signed-off-by: Aaron Schlesinger <[email protected]>

* updating tests:

Signed-off-by: Aaron Schlesinger <[email protected]>

* Updating deployment cache interfaces

To accommodate multi-namespace gets and watches

Signed-off-by: Aaron Schlesinger <[email protected]>

* starting on deployment cache informer

Signed-off-by: Aaron Schlesinger <[email protected]>

* switching over to informer-based deployment cache

Signed-off-by: Aaron Schlesinger <[email protected]>

* fixing test compile errors and merging fake and in-memory deployment caches

Signed-off-by: Aaron <[email protected]>

* fixing tests

Signed-off-by: Aaron Schlesinger <[email protected]>

* fixing more compile errs

Signed-off-by: Aaron Schlesinger <[email protected]>

* improving logging, and several other small changes

Signed-off-by: Aaron Schlesinger <[email protected]>

* go mod tidy

Signed-off-by: Aaron Schlesinger <[email protected]>

* Adding config validation

Signed-off-by: Aaron Schlesinger <[email protected]>

* improving ns and svc name var names to indicate interceptor

Signed-off-by: Aaron Schlesinger <[email protected]>

* running go mod tidy

Signed-off-by: Aaron Schlesinger <[email protected]>

* removing unused code

Signed-off-by: Aaron Schlesinger <[email protected]>

* passing a function to transform target to in-cluster URL

Signed-off-by: Aaron Schlesinger <[email protected]>

* not requiring namespace for operator

Signed-off-by: Aaron Schlesinger <[email protected]>

* splitting namespace config for operator into watch and current

Signed-off-by: Aaron Schlesinger <[email protected]>

* removing appInfo, passing current namespace everywhere in its place

Signed-off-by: Aaron Schlesinger <[email protected]>

* using proper namespace when creating scaled object

Signed-off-by: Aaron Schlesinger <[email protected]>

* allowing xkcd chart to set ingress namespace

Signed-off-by: Aaron Schlesinger <[email protected]>

* printing namespace in error

Signed-off-by: Aaron Schlesinger <[email protected]>

* using proper fully-qualified hostname of external scaler in scaledobject

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding note on cluster-global vs. namespaced mode

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding note about installing the xkcd chart in cluster-global mode

Signed-off-by: Aaron Schlesinger <[email protected]>

* fixing hostname test

Signed-off-by: Aaron Schlesinger <[email protected]>

* merging scaler queue counts with routing table hosts. removing merge functionality from interceptors

Signed-off-by: Aaron Schlesinger <[email protected]>

* fix assumption in tests that queue has all hosts from routing table

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding test for MergeCountsWithRoutingTable

Signed-off-by: Aaron Schlesinger <[email protected]>

* sleep for longer to wait for server to start

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding handler test for merging hosts

Signed-off-by: Aaron Schlesinger <[email protected]>

* adding test to GetMetrics test cases for host not in queue pinger

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* Return custom header when request was returned from a cold start  (kedacore#366)

* Add X-KEDA-HTTP-Cold-Start header

- Add X-KEDA-HTTP-Cold-Start header
- Change signature of forwardWaitFunc to include deployment.Status.ReadyReplicas

Signed-off-by: Aaron Wislang <[email protected]>

* Update tests for X-KEDA-HTTP-Cold-Start header

Signed-off-by: Aaron Wislang <[email protected]>

* Update interceptor/main_test.go

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* add bracket

Signed-off-by: Aaron Wislang <[email protected]>

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* Updating dependencies (kedacore#348)

* updating dependencies

Signed-off-by: Aaron Schlesinger <[email protected]>

* NullLogger => Discard()

Signed-off-by: Aaron Schlesinger <[email protected]>

* removing redundant import

Signed-off-by: Aaron Schlesinger <[email protected]>

* updating to use go 1.17.2

Signed-off-by: Aaron Schlesinger <[email protected]>

* upgrading vulnerable packages

Signed-off-by: Aaron Schlesinger <[email protected]>

* upgrading sftp

Signed-off-by: Aaron Schlesinger <[email protected]>

* force-upgrading sftp

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump go.uber.org/zap from 1.19.1 to 1.20.0 (kedacore#362)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump github.com/go-logr/zapr from 0.4.0 to 1.2.2 (kedacore#357)

Bumps [github.com/go-logr/zapr](https://github.com/go-logr/zapr) from 0.4.0 to 1.2.2.
- [Release notes](https://github.com/go-logr/zapr/releases)
- [Commits](go-logr/zapr@v0.4.0...v1.2.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/zapr
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump k8s.io/apimachinery from 0.23.1 to 0.23.2 (kedacore#376)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.1 to 0.23.2.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.23.1...v0.23.2)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump k8s.io/client-go from 0.23.1 to 0.23.2 (kedacore#375)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.23.1...v0.23.2)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Compile binaries and docker images with git SHA (kedacore#377)

* Compile binaries and docker images with git SHA

Signed-off-by: Aaron Wislang <[email protected]>
Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net>

* Fix test

Signed-off-by: Aaron Wislang <[email protected]>
Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net>

* Apply suggestions from @arschles

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net>

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (kedacore#378)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Configure WhiteSource Bolt for GitHub (kedacore#379)

Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* adding targetPendingRequests to the xkcd helm chart (kedacore#373)

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (kedacore#372)

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* Add TestStreamIsActive (kedacore#384)

* Return IsActive error vs log and continue

Signed-off-by: Aaron Wislang <[email protected]>

* Add TestStreamIsActive

Signed-off-by: Aaron Wislang <[email protected]>

* Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (kedacore#378)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Aaron Wislang <[email protected]>

* Configure WhiteSource Bolt for GitHub (kedacore#379)

Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* adding targetPendingRequests to the xkcd helm chart (kedacore#373)

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (kedacore#372)

Signed-off-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* defer grpcServer.Stop()

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Aaron Wislang <[email protected]>

* Don't check error for gprServer

Signed-off-by: Aaron Wislang <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump go.uber.org/zap from 1.20.0 to 1.21.0 (kedacore#394)

Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.20.0 to 1.21.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.20.0...v1.21.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump google.golang.org/grpc from 1.43.0 to 1.44.0 (kedacore#390)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.43.0 to 1.44.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.43.0...v1.44.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump github.com/onsi/gomega from 1.18.0 to 1.18.1 (kedacore#393)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.18.0...v1.18.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump k8s.io/apimachinery from 0.23.2 to 0.23.3 (kedacore#392)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.2 to 0.23.3.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](kubernetes/apimachinery@v0.23.2...v0.23.3)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Bump k8s.io/api from 0.23.2 to 0.23.3 (kedacore#389)

Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.23.2 to 0.23.3.
- [Release notes](https://github.com/kubernetes/api/releases)
- [Commits](kubernetes/api@v0.23.2...v0.23.3)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Marco Piovesana <[email protected]>

* Update docs/walkthrough.md

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: Marco Piovesana <[email protected]>

Co-authored-by: mpiovesana <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Schlesinger <[email protected]>
Co-authored-by: Aaron Wislang <[email protected]>
Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com>

Bump k8s.io/client-go from 0.23.2 to 0.23.3 (kedacore#391)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.2 to 0.23.3.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.23.2...v0.23.3)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fix scaler crash (kedacore#399)

Signed-off-by: Jakub Leska <[email protected]>

Co-authored-by: Aaron Schlesinger <[email protected]>
@arschles
Copy link
Collaborator Author

I screwed up a rebase on this PR. Closing in favor of the smaller #402.

@arschles arschles closed this Feb 18, 2022
@arschles arschles deleted the update-replicas branch February 18, 2022 00:11
@arschles arschles mentioned this pull request Feb 18, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asw101 asw101 asw101 left review comments

@bketelsen bketelsen bketelsen approved these changes

@tpiperatgod tpiperatgod tpiperatgod approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@ajanth97 ajanth97 Awaiting requested review from ajanth97

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@arschles @tpiperatgod @bketelsen @asw101