Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor errors in magefile. #464

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Fix minor errors in magefile. #464

merged 2 commits into from
Jun 27, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Jun 7, 2022

Signed-off-by: Vighnesh Shenoy [email protected]

Some minor fixes and changes in the magefile.

Checklist

Fixes #

arschles
arschles reviewed Jun 13, 2022
View reviewed changes
magefile.go Outdated Show resolved Hide resolved
magefile.go Outdated Show resolved Hide resolved
@v-shenoy
Copy link
Contributor Author

PTAL @arschles

@v-shenoy
Copy link
Contributor Author

Anything else required here, @arschles?

arschles
arschles approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, thanks @v-shenoy

@arschles arschles merged commit 4fe7e83 into kedacore:main Jun 27, 2022
@v-shenoy v-shenoy deleted the fix-magefile branch June 27, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arschles arschles arschles approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@zroubalik zroubalik Awaiting requested review from zroubalik

@asw101 asw101 Awaiting requested review from asw101

@ajanth97 ajanth97 Awaiting requested review from ajanth97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-shenoy @arschles @tomkerkhove