feat: expose cooldownPeriod param to httpScaledObject #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someshkoli
requested review from
ahmelsayed,
zroubalik,
tomkerkhove,
arschles,
asw101 and
ajanth97
as code owners
- add cooldown to httpScaledObjectSpec - pass cooldown to ScaledObject factory Signed-off-by: Somesh Koli <[email protected]>
someshkoli
force-pushed
the
ft-cooldown-period
branch
from
a6a4d2a to
368a78c
Compare
tomkerkhove
reviewed
Jan 4, 2023
JorTurFer
reviewed
Jan 4, 2023
… of places Signed-off-by: Somesh Koli <[email protected]>
someshkoli
commented
Jan 4, 2023
|
@JorTurFer updated ^ |
JorTurFer
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Somesh Koli [email protected]
Provide a description of what has been changed
Small feature patch for #562
PR exposes scaledobject param from keda core to httpscaledobject and passes down the same to scaledobject
Checklist
README.mddocs/directoryFixes #