Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ARM64 support #573

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 13, 2023

Signed-off-by: Jorge Turrado [email protected]

This PR adds the necessary flows to generate ARM64 images in every push to main (canary tag) and also on every tag pushed to the repo. This PR also adds to e2e test the ARM execution on several k8s versions

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #364

@JorTurFer JorTurFer force-pushed the add-arm64-support branch 3 times, most recently from 7ff0d15 to 5da0b4b Compare January 13, 2023 19:34
@JorTurFer JorTurFer changed the title WIP - Add ARM64 support feat: Add ARM64 support Jan 13, 2023
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer marked this pull request as ready for review January 13, 2023 22:14
@JorTurFer JorTurFer requested a review from a team as a code owner January 13, 2023 22:14
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a ton!

@JorTurFer JorTurFer merged commit 9ac86dd into kedacore:main Jan 16, 2023
@JorTurFer JorTurFer deleted the add-arm64-support branch January 16, 2023 16:07
@morganchristiansson
Copy link

morganchristiansson commented Jan 25, 2023

Also need to upgrade kube-rbac-proxy container image. https://github.com/kedacore/charts/blob/main/http-add-on/values.yaml#L145

Multi-arch was added in 0.6.0 but chart is using 0.5.0. https://github.com/brancz/kube-rbac-proxy/releases

0.6.0 and 0.7.0 are missing from image registry so can use 0.8.0 https://console.cloud.google.com/gcr/images/kubebuilder/global/kube-rbac-proxy?tag=v0.8.0

@JorTurFer
Copy link
Member Author

wow!
Thanks for reporting this because we are planning a new release (which would be wrong without this change).
I'm going to update this ASAP 🙇

@JorTurFer
Copy link
Member Author

Thanks for reporting the issue @morganchristiansson
This PR updates it to latest (I have tested it in my M1, and it works with prometheus operator correctly)

@morganchristiansson
Copy link

Excellent! Thank you for tagging a new release! My keda has in the past broken because it was left on canary image and new changes were merged.

@JorTurFer JorTurFer added this to the v0.4.0 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM support
3 participants