controller: use kedav1alpha1.ScaledObject default values #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-607
branch
from
e186140 to
f5a4de4
Compare
|
@JorTurFer @tomkerkhove, could you take a look at this PR and allow the workflows to run? |
tomkerkhove
reviewed
Feb 24, 2023
There was a problem hiding this comment.
LGTM, but I think it might be best if @JorTurFer reviews as well
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-607
branch
from
f5a4de4 to
e0200ac
Compare
JorTurFer
approved these changes
Feb 25, 2023
JorTurFer
reviewed
Feb 25, 2023
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-607
branch
from
e0200ac to
63db988
Compare
Signed-off-by: Pedro Tôrres <[email protected]>
Signed-off-by: Pedro Tôrres <[email protected]>
Signed-off-by: Pedro Tôrres <[email protected]>
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-607
branch
from
e451dbe to
1271f2d
Compare
JorTurFer
approved these changes
Feb 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the HTTPScaledObject controller use nil instead of Golang Zero Values for optional fields of ScaledObjects.
Checklist
README.mddocs/directoryFixes #607