Remove ScaledObject Custom Labels #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Tôrres <[email protected]>
JorTurFer
approved these changes
Jun 26, 2023
tomkerkhove
reviewed
Jun 26, 2023
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Pedro Tôrres <[email protected]>
Signed-off-by: Pedro Tôrres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some labels were being injected on ScaledObjects managed by the add-on. One of the values of these labels was the name of the HTTPSO prepended by
kedahttp-. This may cause problems because there is a 63-character limit for label values, lower than the 253-character limit of resource names.Since #669, ScaledObjects' names are the same as their respective HTTOSO. And since #704, ownership for ScaledObjects is set. So these labels are no longer required.
Checklist
README.mddocs/directoryFixes #717