Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for integration of keda http addon with istio #953

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

nikhilchintawar
Copy link
Contributor

@nikhilchintawar nikhilchintawar commented Mar 23, 2024

Added documentation for using keda http addon with istio in new file integrations.md.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Any necessary documentation is added, such as:

@nikhilchintawar nikhilchintawar requested a review from a team as a code owner March 23, 2024 09:01
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a massive nit - To align with our marketing guidelines, can you rename "Keda" to "KEDA" please?

Signed-off-by: nikhilchintawar <[email protected]>
@nikhilchintawar
Copy link
Contributor Author

LGTM, but a massive nit - To align with our marketing guidelines, can you rename "Keda" to "KEDA" please?

Done

@tomkerkhove tomkerkhove enabled auto-merge (squash) March 24, 2024 13:36
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME!
Thanks a lot for the contribution! ❤️❤️❤️❤️

@tomkerkhove tomkerkhove merged commit 5839732 into kedacore:main Mar 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants