Skip to content

Commit

Permalink
apply feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Jorge Turrado <[email protected]>
  • Loading branch information
JorTurFer committed Jan 9, 2023
1 parent 8b27631 commit 002a03c
Show file tree
Hide file tree
Showing 16 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion content/docs/1.4/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/1.5/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.0/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.1/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.10/deploy.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ If you want to try KEDA on [Minikube](https://minikube.sigs.k8s.io) or a differe

- We provide sample YAML declaration which includes our CRDs and all other resources in a file which is available on the [GitHub releases](https://github.com/kedacore/keda/releases) page.
- We offer two options to deploy KEDA:
- Use `keda-2.xx.x.yaml` that includes all features, including admission webhooks (recommended)
- Use `keda-2.xx.x.yaml` that includes all features, including [admission webhooks](./concepts/admission-webhooks.md) (recommended)
- Use `keda-2.xx.x-core.yaml` that installs the minimal required KEDA components, without admission webhooks

Run the following command (if needed, replace the version, in this case `2.10.0`, with the one you are using):
Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.10/operate/cluster.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ The KEDA runtime require the following resources in a production-ready setup:

| Deployment | CPU | Memory |
| ------------------ | ----------------------- | ----------------------------- |
| Admission Webhooks | Limit: 1, Request: 100m | Limit: 1000Mi, Request: 100Mi |
| Metrics Server | Limit: 1, Request: 100m | Limit: 1000Mi, Request: 100Mi |
| Operator | Limit: 1, Request: 100m | Limit: 1000Mi, Request: 100Mi |
| Admission Webhooks | Limit: 1, Request: 100m | Limit: 1000Mi, Request: 100Mi |

These are used by default when deploying through YAML.

Expand Down
8 changes: 4 additions & 4 deletions content/docs/2.10/operate/security.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ weight = 100

## Use your own TLS Certificates

KEDA uses self-signed certificates for different things. These certificates are generated and rotated by the operator, storing them in a Kubernetes secret (`kedaorg-certs`) that it's mounted in other KEDA components in the (default) path `/certs` using the names `tls.crt` and `tls.key` for TLS certificate and `ca.crt` and `ca.key` for CA certificate. KEDA also patches Kubernetes resources to include the `caBundle`, making Kubernetes to trust in the CA.
KEDA uses self-signed certificates for different things. These certificates are generated and rotated by the operator. Certificates are stored in a Kubernetes secret (`kedaorg-certs`) that it's mounted to all KEDA components in the (default) path `/certs`. Generated files are named `tls.crt` and `tls.key` for TLS certificate and `ca.crt` and `ca.key` for CA certificate. KEDA also patches Kubernetes resources to include the `caBundle`, making Kubernetes to trust in the CA.

While this is a good starting point, some end-users may want to use their own certificates which are generated from their own CA in order to improve security. This can be done disabling the certificate generation/rotation in the operator and updating default values in other components (if required).
While this is a good starting point, some end-users may want to use their own certificates which are generated from their own CA in order to improve security. This can be done by disabling the certificate generation/rotation in the operator and updating default values in other components (if required).

As the operator is the responsible of generating the certificate for all the services, this behaviour can be disabled removing the console argument `--enable-cert-rotation=true` or setting it to `false`. Once this is disabled, user given certs can be placed in the secret `kedaorg-certs` which is automatically mounted in all the components or they can be patched to use other secret (this can be done throught helm values too).
The KEDA operator is responsible for generating certificates for all the services, this behaviour can be disabled removing the console argument `--enable-cert-rotation=true` or setting it to `false`. Once this setting is disabled, user given certs can be placed in the secret `kedaorg-certs` which is automatically mounted in all the components or they can be patched to use other secret (this can be done throught helm values too).

All the components read the folder `/certs` looking for the certificates inside it, but this folder can be also modifyied using the console argument `--cert-dir`, patching the manifests or using helm values. Due to these certs are also used for internal communication between KEDA components, the CA certificate is also required for registering it as a trusted CA inside KEDA components.
All components inspect the folder `/certs` for any certificates inside it. Argument `--cert-dir` can be used to specify another folder to be used as a source for certificates, this argument can be patched in the manifests or using Helm values. Because these certificates are also used for internal communication between KEDA components, the CA is also required to be registered as a trusted CA inside KEDA components.
2 changes: 1 addition & 1 deletion content/docs/2.2/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.3/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.4/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.5/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.6/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.7/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.8/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
2 changes: 1 addition & 1 deletion content/docs/2.9/concepts/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ KEDA performs two key roles within Kubernetes:

The diagram below shows how KEDA works in conjunction with the Kubernetes Horizontal Pod Autoscaler, external event sources, and Kubernetes' [etcd](https://etcd.io) data store:

![KEDA architecture](/img/keda-arch-old.png)
![KEDA architecture](/img/keda-arch-no-webhooks.png)

### Event sources and scalers

Expand Down
File renamed without changes

0 comments on commit 002a03c

Please sign in to comment.