Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update azure pipeline scaler doc with pod identity auth #1206

Merged
merged 5 commits into from
Jan 16, 2024
Merged

update azure pipeline scaler doc with pod identity auth #1206

merged 5 commits into from
Jan 16, 2024

Conversation

toniiiik
Copy link
Contributor

Update documenttion for azure pipeline scaler using PodIdentity kedacore/keda#4867

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@toniiiik toniiiik requested a review from a team as a code owner August 10, 2023 08:45
@netlify
Copy link

netlify bot commented Aug 10, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit a5267dd
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65a65528cf2e1100082670aa
😎 Deploy Preview https://deploy-preview-1206--keda.netlify.app/docs/2.13/scalers/azure-pipelines
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@toniiiik toniiiik mentioned this pull request Aug 10, 2023
Merged
5 tasks
JorTurFer
JorTurFer reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature will be included as part of v2.13. Cloud you move the changes to that file?

@toniiiik
Copy link
Contributor Author

This feature will be included as part of v2.13. Cloud you move the changes to that file?

done

JorTurFer
JorTurFer approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! PTAL @tomkerkhove

@toniiiik @tomkerkhove
Update content/docs/2.13/scalers/azure-pipelines.md
a5267dd 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: toniiiik <[email protected]>
@tomkerkhove tomkerkhove changed the title update azure pipleline scaler doc with pod identity auth update azure pipeline scaler doc with pod identity auth Jan 16, 2024
@tomkerkhove tomkerkhove merged commit 48abceb into kedacore:main Jan 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toniiiik @tomkerkhove @JorTurFer