Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Elasticsearch example #1287

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix Elasticsearch example #1287

merged 1 commit into from
Jan 10, 2024
+9 −9

Conversation

kevinnoel-be
Copy link
Contributor

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@kevinnoel-be kevinnoel-be requested a review from a team as a code owner January 10, 2024 13:24
@netlify Netlify
Copy link

netlify bot commented Jan 10, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 6d1608e
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/659ec60831467500081d4544
😎 Deploy Preview https://deploy-preview-1287--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@JorTurFer
Copy link
Member

nice catch!
Could you update other versions as well? I think that this happens on all of them

@kevinnoel-be
Fix Elasticsearch example
6d1608e 
Signed-off-by: Kevin NOËL <[email protected]>
@kevinnoel-be
Copy link
Contributor Author

nice catch! Could you update other versions as well? I think that this happens on all of them

Sure, did it for 2.5+

JorTurFer
JorTurFer approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@JorTurFer JorTurFer merged commit 25bc8de into kedacore:main Jan 10, 2024
7 checks passed
@kevinnoel-be kevinnoel-be deleted the patch-1 branch January 10, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinnoel-be @JorTurFer