Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bearer authentication to overview of section authentication parameters #1335

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

uli-f
Copy link
Contributor

@uli-f uli-f commented Mar 15, 2024

What has been changed

Added Bearer authentication to overview of section Authentication Parameters.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@uli-f uli-f requested a review from a team as a code owner March 15, 2024 03:50
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 78014f1
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/660bfd8bc16c6000081dbc8b
😎 Deploy Preview https://deploy-preview-1335--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Could you update v2.14 as well?

@uli-f
Copy link
Contributor Author

uli-f commented Apr 2, 2024

Nice catch! Could you update v2.14 as well?

Sure.

Done in #2e5888b4418d1f52b946362378b7b3d5d43f5c31

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@JorTurFer
Copy link
Member

Could you solve DCO too? You can find all the steps clicking the link
image

@uli-f
Copy link
Contributor Author

uli-f commented Apr 2, 2024

Could you solve DCO too? You can find all the steps clicking the link

Done.

@JorTurFer JorTurFer merged commit 2a405b8 into kedacore:main Apr 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants