Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iam permissions for aws cloudwatch scaler #1347

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Add iam permissions for aws cloudwatch scaler #1347

merged 2 commits into from
Mar 31, 2024

Conversation

robpickerill
Copy link
Contributor

@robpickerill robpickerill commented Mar 28, 2024 •
edited
Loading

Adds documentation to provide examples for the required IAM permissions for the AWS Cloudwatch Scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1329

@robpickerill robpickerill requested a review from a team as a code owner March 28, 2024 16:30
@netlify Netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 0392bda
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6609a0b376200c0008167539
😎 Deploy Preview https://deploy-preview-1347--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@robpickerill robpickerill force-pushed the cloudwatch-iam-permissions branch 3 times, most recently from c95c32a to a0c01c1 Compare March 28, 2024 16:44
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@robpickerill robpickerill force-pushed the cloudwatch-iam-permissions branch from 8053399 to 7260aab Compare March 28, 2024 18:10
JorTurFer
JorTurFer reviewed Mar 31, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! ❤️

Could you update older versions as well?

@robpickerill
add iam docs for all versions
0392bda 
Signed-off-by: Rob Pickerill <[email protected]>
@robpickerill robpickerill force-pushed the cloudwatch-iam-permissions branch from 9c20817 to 0392bda Compare March 31, 2024 17:43
JorTurFer
JorTurFer approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JorTurFer JorTurFer merged commit a52fbd3 into kedacore:main Mar 31, 2024
8 checks passed
@zroubalik zroubalik mentioned this pull request Nov 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document IAM permissions required for the AWS CloudWatch scaler
2 participants
@robpickerill @JorTurFer