Provide "Give KEDA 2.0 (Beta) a test drive" blog post #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
tomkerkhove
requested review from
ahmelsayed,
jeffhollan and
zroubalik
as code owners
tomkerkhove
commented
Aug 17, 2020
Signed-off-by: Tom Kerkhove <[email protected]>
zroubalik
reviewed
Aug 20, 2020
|
We agreed on the call that we will use |
|
Sounds good. Will update asap (🏖️ today) |
ahmelsayed
reviewed
Aug 21, 2020
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
tomkerkhove
changed the title
ahmelsayed
approved these changes
Aug 24, 2020
zroubalik
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
LGTM, we might probably add a note about changing Scalers Metadata - this should be based on the work that @ahmelsayed is doing
Signed-off-by: Tom Kerkhove <[email protected]>
|
Sounds good to me! I've renamed the file so that it doesn't publish (moved date as well) so that we can merge this one and we only have to add new features and publish it when we are done. THanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide "Give KEDA 2.0 (Alpha) a test drive" blog post to announce our alpha preview