Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaml install: need to explicitly create a namespace #57

Merged
merged 1 commit into from
Jan 31, 2020
Merged

yaml install: need to explicitly create a namespace #57

merged 1 commit into from
Jan 31, 2020

Conversation

zroubalik
Copy link
Member

No need to explicitly create a namespace, it gets installed once kedacore/keda#506 PR is merged

Relevant issue: kedacore/keda#505

@zroubalik zroubalik requested a review from ahmelsayed December 9, 2019 18:18
@tomkerkhove
Copy link
Member

The other paths are still correct, right?

@tomkerkhove
Copy link
Member

Ok to merge @zroubalik ?

@zroubalik
Copy link
Member Author

@tomkerkhove yes!

@tomkerkhove tomkerkhove merged commit 9a397a5 into kedacore:master Jan 31, 2020
@tomkerkhove
Copy link
Member

Thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

Assignees

@ahmelsayed ahmelsayed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zroubalik @tomkerkhove @ahmelsayed