Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Datadog Multi-Query Support #885

Merged
merged 6 commits into from
Sep 12, 2022

Conversation

dgibbard-cisco
Copy link
Contributor

@dgibbard-cisco dgibbard-cisco commented Aug 10, 2022

Signed-off-by: Darren Gibbard [email protected]

Documentation to support the Datadog Multi-Query Support added in kedacore/keda#3550

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #3423

@netlify
Copy link

netlify bot commented Aug 10, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 30fbe1f
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6315b3bec90e7c0008c99e71
😎 Deploy Preview https://deploy-preview-885--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dgibbard-cisco
Copy link
Contributor Author

Would be good to get @arapulido 's eyes on this too if available, as the main code creator :)

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nits

content/docs/2.9/scalers/datadog.md Outdated Show resolved Hide resolved
content/docs/2.9/scalers/datadog.md Outdated Show resolved Hide resolved
Signed-off-by: Darren Gibbard <[email protected]>
@dgibbard-cisco
Copy link
Contributor Author

LGTM, a few nits

Thanks for the review! Have made the changes as suggested 👍

Copy link
Contributor

@arapulido arapulido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion. Other than that, LGTM

content/docs/2.9/scalers/datadog.md Show resolved Hide resolved
Signed-off-by: Darren Gibbard <[email protected]>
Copy link
Contributor

@arapulido arapulido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@dgibbard-cisco dgibbard-cisco requested a review from a team as a code owner September 5, 2022 08:30
@JorTurFer JorTurFer merged commit 3f4827b into kedacore:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog Scaler: Support Multi-Query Results
4 participants