Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 2.16.0 #247

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Prepare release 2.16.0 #247

merged 3 commits into from
Nov 8, 2024

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Nov 8, 2024

The first two commits are pre-requisite for the rest of the process. They (1) tidy up the github actions and prepare for switching to go 1.23 and (2) make the relprep script use X.YY instead of X.YY.ZZ versions for envtest, which seems more reliable (and possibly required now).

$ ./hack/relprep.sh 2.16.0
$ go get sigs.k8s.io/structured-merge-diff/[email protected]
$ go mod tidy

Manually downgraded sigs.k8s.io/structured-merge-diff/v4 due to mis-matched struct in v4.4.2.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Tested on OpenShift
  • Tested on vanilla K8s

Fixes #246

@joelsmith joelsmith requested a review from zroubalik as a code owner November 8, 2024 17:02
@joelsmith joelsmith force-pushed the kedamain branch 2 times, most recently from 3e2966f to 7f7b650 Compare November 8, 2024 20:21
* Update golangci version to 1.60 for golang 1.23 (or it will consume
  all memory and eventually be killed by the runner and exit with error
  code 143)
* Update pre-commit to new version and migrate hook names to new names

Signed-off-by: Joel Smith <[email protected]>
Signed-off-by: Joel Smith <[email protected]>
Copy link

github-actions bot commented Nov 8, 2024

Diff 2.16.0/manifests/eventing.keda.sh_cloudeventsources.yaml & 2.15.1/manifests/eventing.keda.sh_cloudeventsources.yaml

6c6
<     controller-gen.kubebuilder.io/version: v0.15.0
---
>     controller-gen.kubebuilder.io/version: v0.16.5
9c9
<     app.kubernetes.io/version: 2.15.1
---
>     app.kubernetes.io/version: 2.16.0
89,90d88
<                       description: CloudEventType contains the list of cloudevent
<                         types
93a92,101
>                       - keda.scaledobject.removed.v1
>                       - keda.scaledjob.ready.v1
>                       - keda.scaledjob.failed.v1
>                       - keda.scaledjob.removed.v1
>                       - keda.authentication.triggerauthentication.created.v1
>                       - keda.authentication.triggerauthentication.updated.v1
>                       - keda.authentication.triggerauthentication.removed.v1
>                       - keda.authentication.clustertriggerauthentication.created.v1
>                       - keda.authentication.clustertriggerauthentication.updated.v1
>                       - keda.authentication.clustertriggerauthentication.removed.v1
98,99d105
<                       description: CloudEventType contains the list of cloudevent
<                         types
102a109,118
>                       - keda.scaledobject.removed.v1
>                       - keda.scaledjob.ready.v1
>                       - keda.scaledjob.failed.v1
>                       - keda.scaledjob.removed.v1
>                       - keda.authentication.triggerauthentication.created.v1
>                       - keda.authentication.triggerauthentication.updated.v1
>                       - keda.authentication.triggerauthentication.removed.v1
>                       - keda.authentication.clustertriggerauthentication.created.v1
>                       - keda.authentication.clustertriggerauthentication.updated.v1
>                       - keda.authentication.clustertriggerauthentication.removed.v1

Copy link

github-actions bot commented Nov 8, 2024

Diff 2.16.0/manifests/keda.v2.16.0.clusterserviceversion.yaml & 2.15.1/manifests/keda.v2.15.1.clusterserviceversion.yaml

29a30,51
>           "apiVersion": "eventing.keda.sh/v1alpha1",
>           "kind": "ClusterCloudEventSource",
>           "metadata": {
>             "labels": {
>               "app.kubernetes.io/created-by": "keda",
>               "app.kubernetes.io/instance": "clustercloudeventsource-sample",
>               "app.kubernetes.io/managed-by": "kustomize",
>               "app.kubernetes.io/name": "clustercloudeventsource",
>               "app.kubernetes.io/part-of": "keda"
>             },
>             "name": "clustercloudeventsource-sample"
>           },
>           "spec": {
>             "clusterName": "clustercluster-sample",
>             "destination": {
>               "http": {
>                 "uri": "http://foo.bar"
>               }
>             }
>           }
>         },
>         {
140c162
<     containerImage: ghcr.io/kedacore/keda-olm-operator:2.15.1
---
>     containerImage: ghcr.io/kedacore/keda-olm-operator:2.16.0
148c170
<   name: keda.v2.15.1
---
>   name: keda.v2.16.0
156a179,181
>     - kind: ClusterCloudEventSource
>       name: clustercloudeventsources.eventing.keda.sh
>       version: v1alpha1
626c651
<                 image: ghcr.io/kedacore/keda-olm-operator:2.15.1
---
>                 image: ghcr.io/kedacore/keda-olm-operator:2.16.0
699c724
<   replaces: keda.v2.15.0
---
>   replaces: keda.v2.15.1
701c726
<   version: 2.15.1
---
>   version: 2.16.0

Copy link

github-actions bot commented Nov 8, 2024

Diff 2.16.0/manifests/keda.sh_scaledobjects.yaml & 2.15.1/manifests/keda.sh_scaledobjects.yaml

6c6
<     controller-gen.kubebuilder.io/version: v0.15.0
---
>     controller-gen.kubebuilder.io/version: v0.16.5
9c9
<     app.kubernetes.io/version: 2.15.1
---
>     app.kubernetes.io/version: 2.16.0
35,40d34
<     - jsonPath: .spec.triggers[*].type
<       name: Triggers
<       type: string
<     - jsonPath: .spec.triggers[*].authenticationRef.name
<       name: Authentication
<       type: string
52a47,52
>     - jsonPath: .status.triggersTypes
>       name: Triggers
>       type: string
>     - jsonPath: .status.authenticationsTypes
>       name: Authentications
>       type: string
318a319,320
>               authenticationsTypes:
>                 type: string
395a398,399
>                 type: string
>               triggersTypes:

Copy link

github-actions bot commented Nov 8, 2024

Diff output of 2.16.0/manifests/keda.sh_scaledjobs.yaml is too large - character limit 65536 exceeded for github comment

Copy link

github-actions bot commented Nov 8, 2024

Diff 2.16.0/manifests/keda.sh_kedacontrollers.yaml & 2.15.1/manifests/keda.sh_kedacontrollers.yaml

6c6
<     controller-gen.kubebuilder.io/version: v0.15.0
---
>     controller-gen.kubebuilder.io/version: v0.16.5
332c332
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
347c347
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
514c514
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
529c529
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
694c694
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
709c709
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
876c876
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
891c891
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
1049d1048
< 
1053d1051
< 
1063a1062,1067
>                             request:
>                               description: |-
>                                 Request is the name chosen for a request in the referenced claim.
>                                 If empty, everything from the claim is made available, otherwise
>                                 only the result of this request.
>                               type: string
1428c1432
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
1443c1447
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
1610c1614
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
1625c1629
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
1790c1794
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
1805c1809
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
1972c1976
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
1987c1991
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
2216d2219
< 
2224d2226
< 
2228d2229
< 
2324d2324
< 
2328d2327
< 
2338a2338,2343
>                             request:
>                               description: |-
>                                 Request is the name chosen for a request in the referenced claim.
>                                 If empty, everything from the claim is made available, otherwise
>                                 only the result of this request.
>                               type: string
2703c2708
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
2718c2723
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
2885c2890
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
2900c2905
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
3065c3070
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
3080c3085
<                                         This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                         This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
3247c3252
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
3262c3267
<                                     This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate.
---
>                                     This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default).
3429d3433
< 
3433d3436
< 
3442a3446,3451
>                               type: string
>                             request:
>                               description: |-
>                                 Request is the name chosen for a request in the referenced claim.
>                                 If empty, everything from the claim is made available, otherwise
>                                 only the result of this request.

Copy link

github-actions bot commented Nov 8, 2024

File 2.16.0/manifests/eventing.keda.sh_clustercloudeventsources.yaml wasn't found in previous version, its brand new!

Copy link

github-actions bot commented Nov 8, 2024

Diff 2.16.0/manifests/keda.sh_triggerauthentications.yaml & 2.15.1/manifests/keda.sh_triggerauthentications.yaml

6c6
<     controller-gen.kubebuilder.io/version: v0.15.0
---
>     controller-gen.kubebuilder.io/version: v0.16.5
9c9
<     app.kubernetes.io/version: 2.15.1
---
>     app.kubernetes.io/version: 2.16.0

Copy link

github-actions bot commented Nov 8, 2024

Diff 2.16.0/manifests/keda.sh_clustertriggerauthentications.yaml & 2.15.1/manifests/keda.sh_clustertriggerauthentications.yaml

6c6
<     controller-gen.kubebuilder.io/version: v0.15.0
---
>     controller-gen.kubebuilder.io/version: v0.16.5
9c9
<     app.kubernetes.io/version: 2.15.1
---
>     app.kubernetes.io/version: 2.16.0

@jkyros
Copy link
Contributor

jkyros commented Nov 8, 2024

Looks great! Lots of cloudeventsource stuff this time. It's a shame about golangci-lint, but glad you got to the bottom of it 😄
/lgtm

@joelsmith joelsmith merged commit 8cb33dd into kedacore:main Nov 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 2.16.0
2 participants