fix: fix isFallbackEnabled when using scaling modifiers

Signed-off-by: Youssef Rabie <[email protected]>
kedacore · Feb 2, 2025 · 96d98ae · 96d98ae
1 parent d76aa17
commit 96d98ae
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/fallback/fallback.go b/pkg/fallback/fallback.go
@@ -38,7 +38,12 @@ func isFallbackEnabled(scaledObject *kedav1alpha1.ScaledObject, metricSpec v2.Me
 		return false
 	}
 
-	if metricSpec.External.Target.Type != v2.AverageValueMetricType {
+	// If we are using ScalingModifiers, we only care whether its metric type is AverageValue.
+	// If not, test the type of metricSpec passed.
+	if scaledObject.IsUsingModifiers() && scaledObject.Spec.Advanced.ScalingModifiers.MetricType != v2.AverageValueMetricType {
+		log.V(0).Info("Fallback can only be enabled for scalingModifiers with metric of type AverageValue", "scaledObject.Namespace", scaledObject.Namespace, "scaledObject.Name", scaledObject.Name)
+		return false
+	} else if !scaledObject.IsUsingModifiers() && metricSpec.External.Target.Type != v2.AverageValueMetricType {
 		log.V(0).Info("Fallback can only be enabled for triggers with metric of type AverageValue", "scaledObject.Namespace", scaledObject.Namespace, "scaledObject.Name", scaledObject.Name)
 		return false
 	}