Update mongo_scaler_test.go

Signed-off-by: rickbrouwer <[email protected]>

pkg/scalers/mongo_scaler_test.go

@@ -2,8 +2,6 @@ package scalers
 
 import (
 	"context"
-	"net"
-	"net/url"
 	"testing"
 
 	"github.com/go-logr/logr"
@@ -102,62 +100,25 @@ var mongoDBMetricIdentifiers = []mongoDBMetricIdentifier{
 
 func TestParseMongoDBMetadata(t *testing.T) {
 	for _, testData := range testMONGODBMetadata {
-		meta, err := parseMongoDBMetadata(&scalersconfig.ScalerConfig{ResolvedEnv: testData.resolvedEnv, TriggerMetadata: testData.metadata, AuthParams: testData.authParams})
+		_, err := parseMongoDBMetadata(&scalersconfig.ScalerConfig{ResolvedEnv: testData.resolvedEnv, TriggerMetadata: testData.metadata, AuthParams: testData.authParams})
 		if err != nil && !testData.raisesError {
 			t.Error("Expected success but got error:", err)
 		}
 		if err == nil && testData.raisesError {
 			t.Error("Expected error but got success")
 		}
-		if err == nil {
-			err = meta.Validate()
-			if err != nil && !testData.raisesError {
-				t.Error("Expected success but got error:", err)
-			}
-			if err == nil && testData.raisesError {
-				t.Error("Expected error but got success")
-			}
-		}
 	}
 }
 
 func TestParseMongoDBConnectionString(t *testing.T) {
 	for _, testData := range mongoDBConnectionStringTestDatas {
-		meta, err := parseMongoDBMetadata(&scalersconfig.ScalerConfig{
+		_, err := parseMongoDBMetadata(&scalersconfig.ScalerConfig{
 			ResolvedEnv:     testData.metadataTestData.resolvedEnv,
 			TriggerMetadata: testData.metadataTestData.metadata,
 			AuthParams:      testData.metadataTestData.authParams,
 		})
 		if err != nil {
 			t.Error("Expected success but got error:", err)
-			continue
-		}
-
-		var connString string
-		if meta.ConnectionString != "" {
-			connString = meta.ConnectionString
-		} else {
-			if meta.Scheme == "mongodb+srv" {
-				u := &url.URL{
-					Scheme: meta.Scheme,
-					User:   url.UserPassword(meta.Username, meta.Password),
-					Host:   meta.Host,
-					Path:   meta.DBName,
-				}
-				connString = u.String()
-			} else {
-				u := &url.URL{
-					Scheme: meta.Scheme,
-					User:   url.UserPassword(meta.Username, meta.Password),
-					Host:   net.JoinHostPort(meta.Host, meta.Port),
-					Path:   meta.DBName,
-				}
-				connString = u.String()
-			}
-		}
-
-		if connString != testData.connectionString {
-			t.Errorf("Expected connection string %s but got %s", testData.connectionString, connString)
 		}
 	}
 }