remove allElementsExist, use direct count comparison for requireAllDe…

…mandsAndIgnoreOthers
kedacore · Jun 3, 2024 · b3f23ba · b3f23ba
1 parent 80b7e30
commit b3f23ba
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/pkg/scalers/azure_pipelines_scaler.go b/pkg/scalers/azure_pipelines_scaler.go
@@ -497,22 +497,12 @@ func getCanAgentDemandFulfilJob(jr JobRequest, metadata *azurePipelinesMetadata)
 
 	if metadata.requireAllDemands {
 		return countDemands == len(demandsInJob) && countDemands == len(demandsInScaler)
-	}
-	if metadata.requireAllDemandsAndIgnoreOthers {
-		return allElementsExist(demandsInScaler, demandsInJob)
+	} else if metadata.requireAllDemandsAndIgnoreOthers {
+		return countDemands == len(demandsInScaler)
 	}
 	return countDemands == len(demandsInJob)
 }
 
-func allElementsExist(a, b []string) bool {
-	for _, elem := range a {
-		if !contains(b, elem) {
-			return false
-		}
-	}
-	return true
-}
-
 // Determine if the Job and Parent Agent Template have matching capabilities
 func getCanAgentParentFulfilJob(jr JobRequest, metadata *azurePipelinesMetadata) bool {
 	matchedAgents := jr.MatchedAgents