Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make controllers/ golint compatible #1055

Closed
4 tasks
turbaszek opened this issue Aug 28, 2020 · 0 comments · Fixed by #1065
Closed
4 tasks

Make controllers/ golint compatible #1055

turbaszek opened this issue Aug 28, 2020 · 0 comments · Fixed by #1065
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers Hacktoberfest

Comments

@turbaszek
Copy link
Contributor

KEDA uses golint to ensure code quality. However, some files still need adjusting:

  • controllers/scaledjob_controller.go
  • controllers/scaledobject_controller.go
  • controllers/util/status.go
  • controllers/util/string_lists.go

How

  1. Create a new branch from v2branch
  2. Remove the files from list in .pre-commit-config.yaml
  3. Either run pre-commit go-lint --all-files (this requires installed pre-commit) or golint path/to/selected/file.go
  4. Commit your changes and open a PR to v2

Reference

#1025 (comment)

@turbaszek turbaszek added feature-request All issues for new features that have not been committed to needs-discussion labels Aug 28, 2020
@zroubalik zroubalik added good first issue Good for newcomers and removed needs-discussion labels Aug 28, 2020
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants