Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure k8s Metrics Adapter for integration with HPA #152

Closed
tomkerkhove opened this issue May 7, 2019 · 5 comments
Closed

Support Azure k8s Metrics Adapter for integration with HPA #152

tomkerkhove opened this issue May 7, 2019 · 5 comments

Comments

@tomkerkhove
Copy link
Member

Disclaimer: I haven't checked the code so this might already be the case

Why does Keda use MSFTs own metrics adapter instead of adopting the Azure k8s Metrics Adapter to integrate with the HPA?

Is it because it's based on other metrics than Azure Monitor or a different reason?
Based on the docs it's not really clear to me where it's getting the metrics from.

@yaron2
Copy link
Contributor

yaron2 commented May 7, 2019

KEDA is a cloud agnostic, vendor neutral project and thus cannot use an Azure only software component.

Even for Azure services, the reliance on Azure Monitor is problematic for a multitude of reasons.

KEDA has a concept of scalers - each scaler is autonomous in implementing the means by which its getting its metrics.

@tomkerkhove
Copy link
Member Author

That makes sense, I think my question is more why doesn't Keda integrate with existing metric servers which we can plug in.

For example Ive just opened #156 for Prometheus support, which has a metrics server already, and #155 which improves Monitor support while we could plug in the one mentioned above.

/cc @jeffhollan

@yaron2
Copy link
Contributor

yaron2 commented May 7, 2019

Was just talking about Prometheus yesterday :)

Thats indeed a very powerful feature.

@yaron2
Copy link
Contributor

yaron2 commented May 7, 2019

Closing this as we have #155 and #156 to track

@yaron2 yaron2 closed this as completed May 7, 2019
@tomkerkhove
Copy link
Member Author

Fair enough, thanks for following-up!

preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants