Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Scalers: Use our own chained TokenCredential with MSI, WI and CLI #4029

Closed
JorTurFer opened this issue Dec 20, 2022 · 1 comment
Closed
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Dec 20, 2022

Proposal

We use azure-sdk-for-go in several scaler (and eventually we will migrate others when they are available) and the new identity sdk introduces already defined TokenCredential for several authetication flows. Currently, we have a single option on each case but we could have a chained TokenCredential which tries with all the already configured flows, having a unified code for both pod identities and also for local development.
Now we don't have any way to troubleshoot/debug a scaler that uses azure pod identities as we can't get the token, but if we unify them in a single chained TokenCredential, we could debug it locally, having the same behaviour that we could expect in the cluster, making the experience so much better.

This improvement has some requisites before being doable:

@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Dec 20, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Dec 20, 2022
@JorTurFer JorTurFer moved this from Proposed to To Do in Roadmap - KEDA Core Dec 20, 2022
@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Dec 20, 2022
@JorTurFer
Copy link
Member Author

This can't be done because we have to support split chains because end users could have both auths working together in the same cluster with different roles.

@JorTurFer JorTurFer closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
@github-project-automation github-project-automation bot moved this from To Do to Ready To Ship in Roadmap - KEDA Core Feb 8, 2023
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Archived in project
Development

No branches or pull requests

1 participant