Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use new SDK with proper errors for service bus with pod identity #4030

Merged
merged 8 commits into from
Jan 13, 2023
Merged

fix: Use new SDK with proper errors for service bus with pod identity #4030

merged 8 commits into from
Jan 13, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Dec 20, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado [email protected]

This PR is a fix for #4026 until we can do this

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4026

@JorTurFer JorTurFer force-pushed the fix-sb-pod-indentity branch from 35b4065 to f083d3e Compare December 21, 2022 00:16
This was referenced Jan 9, 2023
Merged
Merged
@JorTurFer JorTurFer force-pushed the fix-sb-pod-indentity branch 2 times, most recently from 6f38f71 to 3c427f5 Compare January 9, 2023 23:14
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 10, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer JorTurFer marked this pull request as ready for review January 10, 2023 07:37
@JorTurFer JorTurFer requested a review from a team as a code owner January 10, 2023 07:37
@JorTurFer JorTurFer mentioned this pull request Jan 10, 2023
Closed
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 10, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Jan 10, 2023
Closed
@JorTurFer JorTurFer force-pushed the fix-sb-pod-indentity branch from 351821f to 0cea94b Compare January 10, 2023 10:40
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 10, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer
use the SDK
2bcf6d7 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
update styles
6669689 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer changed the title fix: Revert service bus pod identity unification fix: Use new SDK with proper errors for service bus with pod identity Jan 12, 2023
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 12, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer
fix deprecated ioutils usage
641bbdc 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
add comment
951de3b 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 13, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer
remove unecessary code
b8df923 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 13, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@zroubalik zroubalik merged commit c161148 into kedacore:main Jan 13, 2023
@JorTurFer JorTurFer deleted the fix-sb-pod-indentity branch January 13, 2023 12:13
mfadhlika pushed a commit to mfadhlika/keda that referenced this pull request Jan 13, 2023
@JorTurFer @mfadhlika
fix: Use new SDK with proper errors for service bus with pod identity (…
3479561 
…kedacore#4030)

Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Jan 16, 2023
@JorTurFer @zroubalik
fix: Use new SDK with proper errors for service bus with pod identity (…
038c00c 
…kedacore#4030)

Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@zroubalik zroubalik mentioned this pull request Jan 16, 2023
Merged
zroubalik added a commit that referenced this pull request Jan 16, 2023
@zroubalik @JorTurFer
fix: Use new SDK with proper errors for service bus with pod identity (…
b056b9e 
…#4030) (#4118)

Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
This was referenced Feb 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keda 2.9.1 on AKS with Pod-Identity Looks for AzureCLICredential-
2 participants
@JorTurFer @zroubalik