v1.0.0 - Rabbitmq Scaler not scaling past 1.

[Jinkxed]

A clear and concise description of what the bug is.

Expected Behavior

Scale target should scale to maxreplicaCount specification.

Actual Behavior

Scale target scales to 1.

Errors in the log show:

{"level":"error","ts":1575675604.989792,"logger":"scalehandler","msg":"Error updating scaledObject status","ScaledObject.Namespace":"us-east-1-stg","ScaledObject.Name":"signal-worker","ScaledObject.ScaleType":"deployment","error":"Operation cannot be fulfilled on scaledobjects.keda.k8s.io \"signal-worker\": the object has been modified; please apply your changes to the latest version and try again","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).updateScaledObjectStatus\n\tkeda/pkg/handler/scale_handler.go:47\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).scaleDeployment\n\tkeda/pkg/handler/scale_deployments.go:35\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).handleScaleDeployment\n\tkeda/pkg/handler/scale_loop.go:130\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).handleScale\n\tkeda/pkg/handler/scale_loop.go:45\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).HandleScaleLoop\n\tkeda/pkg/handler/scale_loop.go:28"}

Seeing this error message for every scaled object deployed.

Code Used:

kind: ScaledObject
metadata:
  name: "signal-worker"
  labels:
    application: "signal-worker"
    namespace: "us-east-1-stg"
    helm.sh/chart: {{ include "..chart" . }}
spec:
  minReplicaCount: 0
  maxReplicaCount: 20
  scaleTargetRef:
    deploymentName: "signal-worker"
  triggers:
  - type: rabbitmq
    metadata:
      host: RABBITMQ_URL
      queueName: "some_rabbit_queue"
      queueLength: "1"

[jeffhollan]

I think it's because you are missing the deploymentName label in the ScaledObject.

https://keda.sh/concepts/scaling-deployments/

Let me know if that fixes it, as at the very least we should make the error much better here

[Jinkxed]

Yup - that fixed it. Not sure how I missed something so simple, but very much appreciate the quick response!

[jeffhollan]

Thanks - I'll create a bug right now that we should fix this error message.