Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when missing label is not helpful #504

Closed
jeffhollan opened this issue Dec 7, 2019 · 0 comments · Fixed by #532
Closed

Error when missing label is not helpful #504

jeffhollan opened this issue Dec 7, 2019 · 0 comments · Fixed by #532
Assignees
@zroubalik
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Looking for support from community

Comments

@jeffhollan
Copy link
Member

Per this bug #503 the error that we log when a ScaledObject is missing the label for deploymentName isn't super helpful.

I don't even remember why we have to duplicate this data between label and scaleTargetRef, but regardless, ideally at least the error could be something referencing the fact that this label is missing
@jeffhollan jeffhollan added enhancement New feature or request help wanted Looking for support from community good first issue Good for newcomers labels Dec 7, 2019
@zroubalik zroubalik self-assigned this Jan 3, 2020
@zroubalik zroubalik mentioned this issue Jan 3, 2020
Merged
@tomkerkhove tomkerkhove mentioned this issue Jan 16, 2020
Closed
preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
@tomkerkhove
docs: Publish KEDA v2.4 docs (kedacore#504)
0e961d8 
Signed-off-by: Tom Kerkhove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zroubalik zroubalik

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Looking for support from community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve check of deploymentName definition in ScaledObject zroubalik/keda
2 participants
@zroubalik @jeffhollan