[v2] Remove minReplicaCount and cooldownPeriod from ScaledJob

[TsuyoshiUshio]

A clear and concise description of what you want to happen.

Use-Case

For the ScaledJob on v2, minReplicaCount and coolddownPeriod is not make sense for ScaledJob.
I want to remove before release v2 beta. Do you agree with it?

Specification

apiVersion: v1
kind: Secret
metadata:
  name: rabbitmq-consumer
data:
  RabbitMqHost: YW1xcDovL3VzZXI6UEFTU1dPUkRAcmFiYml0bXEuZGVmYXVsdC5zdmMuY2x1c3Rlci5sb2NhbDo1Njcy
  LocalHost: YW1xcDovL3VzZXI6UEFTU1dPUkRAMTI3LjAuMC4xOjU2NzI=
---
apiVersion: keda.sh/v1alpha1
kind: ScaledJob
metadata:
  name: rabbitmq-consumer
  namespace: default
spec:
  jobTargetRef:
    template:
      spec:
        containers:
        - name: rabbitmq-client
          image: tsuyoshiushio/rabbitmq-client:dev3
          imagePullPolicy: Always
          command: ["receive",  "amqp://user:[email protected]:5672", "job"]
          envFrom:
            - secretRef:
                name: rabbitmq-consumer
        restartPolicy: Never
    backoffLimit: 4  
  pollingInterval: 10   # Optional. Default: 30 seconds
  cooldownPeriod: 30   # Optional. Default: 300 seconds   **<- removed from ScaledJob**
  minReplicaCount: 0    # Optional.  **<- removed from ScaledJob**
  maxReplicaCount: 30  # Optional. Default: 100

[tomkerkhove]

Makes sense.

[TsuyoshiUshio]

Thank you, @tomkerkhove
I'll create a new pr for this issue for v2!

[tomkerkhove]

Looks like our CRD is outdated: https://github.com/kedacore/keda/blob/v2/deploy/crds/keda.sh_scaledjobs_crd.yaml

[TsuyoshiUshio]

Good catch! Thanks!

[zroubalik]

Fixing in #971

[TsuyoshiUshio]

Thanks. 👍

[NamanChandra1]

I need this parameter for my scaledjob. What if i want the scaler to activate 1 hour after the previous run? In that use case I can set cooldownperiod as 1 hour.

Correct me if I am missing something