Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add MetricsAPIScaler #1026

Merged
merged 7 commits into from
Sep 3, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check API health when creating new scaler
Signed-off-by: Tomek Urbaszek <[email protected]>
turbaszek committed Aug 26, 2020
commit 71881473fa85d35bc140e6300c4b80f603d683c4
18 changes: 15 additions & 3 deletions pkg/scalers/metrics_api_scaler.go
Original file line number Diff line number Diff line change
@@ -38,9 +38,15 @@ var httpLog = logf.Log.WithName("metrics_api_scaler")
func NewMetricsAPIScaler(resolvedEnv, metadata, authParams map[string]string) (Scaler, error) {
meta, err := metricsAPIMetadata(resolvedEnv, metadata, authParams)
if err != nil {
return nil, fmt.Errorf("error parsing HTTP metadata: %s", err)
return nil, fmt.Errorf("error parsing metric API metadata: %s", err)
}
return &metricsAPIScaler{metadata: meta}, nil
scaler := &metricsAPIScaler{metadata: meta}
err = scaler.checkHealth()
if err != nil {
return nil, fmt.Errorf("error checking metric API health/ endpoint: %s", err)
}

return scaler, nil
}

func metricsAPIMetadata(resolvedEnv, metadata, authParams map[string]string) (*metricsAPIScalerMetadata, error) {
@@ -72,6 +78,12 @@ func metricsAPIMetadata(resolvedEnv, metadata, authParams map[string]string) (*m
return &meta, nil
}

func (s *metricsAPIScaler) checkHealth() error {
u := fmt.Sprintf("%s/health/", s.metadata.url)
_, err := http.Get(u)
return err
}

func (s *metricsAPIScaler) getMetricInfo() (*metric, error) {
var m *metric
u := fmt.Sprintf("%s/metrics/%s/", s.metadata.url, s.metadata.metricName)
@@ -100,7 +112,7 @@ func (s *metricsAPIScaler) Close() error {
func (s *metricsAPIScaler) IsActive(ctx context.Context) (bool, error) {
m, err := s.getMetricInfo()
if err != nil {
httpLog.Error(err, fmt.Sprintf("Error when checking API health: %s", err))
httpLog.Error(err, fmt.Sprintf("Error when checking metric value: %s", err))
return false, err
}